Repository navigation
fix: retry hash clients when timeouts are reached - #655
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HashClient waits until elapsed time is strictly greater than its retry/dead timeout. With a zero timeout, a second call in the same clock tick therefore skips the retry or reports that all servers are down. This also makes the existing immediate-retry tests depend on clock resolution.
Treat the timeout as elapsed when the interval equals the configured value, consistently for ordinary commands, set_many, and dead-server recovery. Freeze the clock in the existing zero-timeout tests and add boundary coverage for zero and positive retry timeouts. The positive-timeout cases also verify that calls before the deadline do not retry.
Validation: two existing tests with a frozen clock and four new boundary cases fail before the change. The unit run after the fix has 496 passed, one skipped, and one Windows-only failure because this Python build lacks AF_UNIX. Black 24.4.2, Flake8 7.1.1, and diff whitespace checks pass. Compression tests were excluded because zstd could not be built locally; live memcached integration tests were not run.